Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA1065: Ignore System.Diagnostics.UnreachableException #7200

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

mpidash
Copy link
Contributor

@mpidash mpidash commented Feb 19, 2024

Fixes #6001.

@mpidash mpidash requested a review from a team as a code owner February 19, 2024 23:06
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ab13ac7) 96.45% compared to head (9b3cf64) 96.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7200   +/-   ##
=======================================
  Coverage   96.45%   96.45%           
=======================================
  Files        1422     1422           
  Lines      340585   340604   +19     
  Branches    11230    11230           
=======================================
+ Hits       328511   328536   +25     
+ Misses       9236     9231    -5     
+ Partials     2838     2837    -1     

Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @mpidash!

@buyaa-n buyaa-n merged commit 6fcb27c into dotnet:main Feb 27, 2024
14 checks passed
@mpidash mpidash deleted the issue-6001 branch February 27, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CA1065 should probably be made to ignore System.Diagnostics.UnreachableException
2 participants