Fix Azure Queue Streaming IConfiguration provider #9320
Merged
+148
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Azure/Orleans.Streaming.AzureStorage/Hosting/ClientBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/Azure/Orleans.Streaming.AzureStorage/Hosting/SiloBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
benjaminpetit
approved these changes
Feb 7, 2025
ReubenBond
force-pushed
the
fix/aq-streaming-provider-and-tests
branch
from
cd722ad to
5e52c3d
Compare
ReubenBond
force-pushed
the
fix/aq-streaming-provider-and-tests
branch
from
5e52c3d to
60fd16d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the Table & Blob clients, the Queue client's constructor taking a single URI expects that URI to contain a shared access signature. This PR changes the way we construct the queue client to check if the URI is a SAS URI and, if not, call an alternative constructor which accepts a token credential.
In tests, we use the Asire Azure Storage Queues package to configure a client.
Microsoft Reviewers: Open in CodeFlow