Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove restriction limiting reminders to a maximum of 49 days #9319

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

willg1983
Copy link
Contributor

@willg1983 willg1983 commented Feb 7, 2025

This PR removes the maximum limit of 49.7 days on reminders.

Creating a reminder with either a dueTime or period greater than 4294967294ms results in an exception.

This was originally raised here #1298 and work was done in #6342 to switch the LocalReminderService to use IAsyncTimerFactory which handles scenarios involving intervals longer than those supported by .NET timers.

It looks like however, the parameter validation for RegisterOrUpdateReminder was not updated as part of that PR, so the restriction remains.

There remains some risk the underlying IReminderTable implementations will make assumptions about the maximum value possible, for example the ADO.NET Reminders Table was updated to store the dueTime and period as long instead of int in this PR #6390 other implementations in the Orleans codebase appear to either use ReminderEntry directly or serialize it to Json.

Bypassing Current Limits on Reminders is mentioned as part of the proposal for Reminders V2
#7573

Microsoft Reviewers: Open in CodeFlow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant