chore(Orleans.Runtime): Use LoggerMessageGenerator for core logging messages

[Meir017]

part of #9273

Microsoft Reviewers: Open in CodeFlow

[Meir017]

@ReubenBond I'm not sure if it's possible to convert the log

if (logger.IsEnabled(LogLevel.Debug)) logger.LogDebug("CollectActivations {Activations}", list.ToStrings(d => d.GrainId.ToString() + d.ActivationId));

to the LoggerMessage syntax, is it possible to have custom formatter for parameters? (to call the .ToStrings method conditionally like you're doing now) - this type of optimization appears in multiple locations

[ReubenBond]

This is a very costly log line... You could convert the LogDebug call but keep the IsEnabled guard to prevent massive unnecessary memory allocation. I'd also consider bumping this to Trace since it's extremely verbose.

[Meir017]

@ReubenBond I wonder if we could introduce a utility struct to simplify this

private struct ActivationsLogValue(List<ICollectibleGrainContext> list)
{
    public override string ToString() => list.ToStrings(d => d.GrainId.ToString() + d.ActivationId);
}

and then have the logging method have an argument of type ActivationsLogValue

[Meir017]

@ReubenBond thoughts on this?

[ReubenBond]

Good idea. Please also switch the level to to Trace if you change this