Skip to content

Conversation

@rmarinho
Copy link
Member

Description of Change

Running darc to update ".NET Eng'

 darc update-dependencies --channel ".NET Eng - Latest" --verbose

@rmarinho rmarinho added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Apr 14, 2025
Copilot AI review requested due to automatic review settings April 14, 2025 18:25
@rmarinho rmarinho requested a review from a team as a code owner April 14, 2025 18:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates Arcade dependencies by running the darc update-dependencies command and adjusts YAML configuration files accordingly. The changes include updating the microbuild installation script to dynamically choose a build folder using version regex matching, introducing a new parameter (isAssetlessBuild) in post-build configuration, and conditioning asset publishing tasks based on the new parameter.

Reviewed Changes

Copilot reviewed 3 out of 10 changed files in this pull request and generated no comments.

File Description
eng/common/core-templates/steps/install-microbuild.yml Updates folder path logic with regex-based version detection
eng/common/core-templates/post-build/post-build.yml Adds new boolean parameter isAssetlessBuild
eng/common/core-templates/job/publish-build-assets.yml Adds isAssetlessBuild parameter and adjusts asset publishing tasks based on its value
Files not reviewed (7)
  • .config/dotnet-tools.json: Language not supported
  • NuGet.config: Language not supported
  • eng/Version.Details.xml: Language not supported
  • eng/Versions.props: Language not supported
  • eng/common/post-build/publish-using-darc.ps1: Language not supported
  • eng/common/sdl/packages.config: Language not supported
  • global.json: Language not supported
Comments suppressed due to low confidence (3)

eng/common/core-templates/steps/install-microbuild.yml:96

  • Ensure that the regex pattern correctly matches the intended version directories in all cases, including any potential pre-release or build metadata scenarios.
$versionRegex = '\d+\.\d+\.\d+'

eng/common/core-templates/job/publish-build-assets.yml:79

  • Verify that comparing the boolean parameter isAssetlessBuild to the string 'false' works as expected. Consider using a boolean comparison if the pipeline supports it.
- ${{ if eq(parameters.isAssetlessBuild, 'false') }}:

eng/common/core-templates/job/publish-build-assets.yml:132

  • Review the logical condition here to ensure it correctly handles the boolean value of isAssetlessBuild; the string comparison may lead to unexpected behavior.
- ${{ if or(eq(parameters.publishAssetsImmediately, 'true'), eq(parameters.isAssetlessBuild, 'true')) }}:

@rmarinho rmarinho merged commit f97d79f into net10.0 Apr 15, 2025
116 of 128 checks passed
@rmarinho rmarinho deleted the update-arcadenet10 branch April 15, 2025 11:50
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants