Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] FileSystem.Current.AppDataDirectory returns different path after updating to latest version - fix #26039

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Windows] FileSystem.Current.AppDataDirectory returns different path after updating to latest version - fix #26039

wants to merge 1 commit into from
+1 −1

Conversation

MartyIX
Copy link
Contributor

@MartyIX MartyIX commented Nov 21, 2024 •
edited
Loading

Description of Change

Unfortunately #23265 introduced a regression. This PR attempts to fix it.

The regression was introduced because this line:

Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData), AppSpecificPath, "Data");

was translated to this line:

Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData), AppSpecificPath, "Data");

Issues Fixed

Fixes #25981

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Nov 21, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Hey there @MartyIX! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@MartyIX MartyIX changed the title FileSystem.Current.AppDataDirectory returns different path after updating to latest version - fix [Windows] FileSystem.Current.AppDataDirectory returns different path after updating to latest version - fix Nov 21, 2024
@MartyIX MartyIX mentioned this pull request Nov 21, 2024
Open
@MartyIX MartyIX marked this pull request as ready for review November 21, 2024 20:24
@MartyIX MartyIX requested a review from a team as a code owner November 21, 2024 20:24
@PureWeen
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen added this to the .NET 9 SR2 milestone Nov 21, 2024
mattleibow
mattleibow approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel bad I missed this 5-letter difference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattleibow mattleibow mattleibow approved these changes

@rmarinho rmarinho Awaiting requested review from rmarinho rmarinho is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees

@Foda Foda

@mattleibow mattleibow

Labels
community ✨ Community Contribution platform/windows 🪟
Projects
MAUI SDK Ongoing
Status: Approved
Milestone
.NET 9 SR2
Development

Successfully merging this pull request may close these issues.

FileSystem.Current.AppDataDirectory returns different path after updating to latest version
4 participants
@MartyIX @PureWeen @mattleibow @Foda