Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fall back to loading .NET 8 date strings #26033

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fall back to loading .NET 8 date strings #26033

wants to merge 1 commit into from
+28 −3

Conversation

mattleibow
Copy link
Member

@mattleibow mattleibow commented Nov 21, 2024 •
edited
Loading

Description of Change

This has to do with the different implementations of the preferences API on Windows depending on packaged or unpackaged.

  • The .NET 8 template was packaged
  • The .NET 9 template was unpackaged

The implementation differs:

  • packaged uses the ApplicationDataContainer APIs and stores as long and cannot be retrieved as string
  • unpackaged uses a string dictionary that is serialized to a file

The real change comes in at #22815 where that PR had this line: https://github.com/dotnet/maui/pull/22815/files#diff-6ed591e38dc7754551705bf5bb96f992115c384d19166e8dcda76267e177fb0cR196-R197

In .NET 8 everything was a "ToString" system for unpackaged. In .NET 9 there is now a ToBinary.

Issues Fixed

Fixes #25930

@mattleibow mattleibow requested a review from a team as a code owner November 21, 2024 19:08
@mattleibow mattleibow added the area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info label Nov 21, 2024
@PureWeen PureWeen added this to the .NET 9 SR2 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Foda Foda Foda approved these changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@jfversluis jfversluis Awaiting requested review from jfversluis jfversluis is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

At least 1 approving review is required to merge this pull request.

Assignees

@Foda Foda

Labels
area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info
Projects
MAUI SDK Ongoing
Status: Approved
Milestone
.NET 9 SR2
Development

Successfully merging this pull request may close these issues.

Preferences DateTime Storage Issues
3 participants
@mattleibow @Foda @PureWeen