Add fallback to ContentPresenter Content binding using reflection #25992
+116
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
requested changes
Nov 21, 2024
| @@ -19,12 +21,38 @@ public class ContentPresenter : Compatibility.Layout, IContentView | |||
| /// <include file="../../docs/Microsoft.Maui.Controls/ContentPresenter.xml" path="//Member[@MemberName='.ctor']/Docs/*" /> | |||
| public ContentPresenter() | |||
| { | |||
| this.SetBinding( | |||
| SetBinding( | |||
There was a problem hiding this comment.
The test RadioButtonWithValueChangeSelected is failing on iOS.
Is not rendering the Content, the text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
It turns out that for customers that are deriving from
TemplatedViewrun into issues with theContentPresenterand the binding for theContentproperty.AFAIK we currently don't have any docs that would mention how to implement custom
TemplatedViewthat could be updated to mention that the "proper" way to do this is to implement theobject IContentView.Contentproperty in the derived class. I added runtime warning but I'm not sure how many developers will actually see this or just miss it completely.cc @PureWeen @mattleibow @StephaneDelcroix @davidbritch
Issues Fixed
Fixes #25947