Border.Shadow hide the collectionView Header/footer - fix #25960
+77
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/rebase |
github-actions
bot
force-pushed
the
fix-19338
branch
from
1dbc405
to
c6982c9
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Nov 20, 2024
| public void Issue935TestsMultipleOnTappedViewCell() | ||
| { | ||
| App.WaitForElement("HeaderLabel"); | ||
| VerifyScreenshot(); |
There was a problem hiding this comment.
Snapshots available in the latest build:
Could you commit the images?
There was a problem hiding this comment.
I had to add margin to the collection, so I need to re-upload screenshots
|
/rebase |
github-actions
bot
force-pushed
the
fix-19338
branch
from
aaab2d4
to
0b8f1cf
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run maui-pr |
|
No pipelines are associated with this pull request. |
jsuarezruiz
added
area-controls-collectionview
jsuarezruiz
requested changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Whenever a view, wrapped inside a wrapper view, has been a direct child of a header or footer element, it either didn't show at all or rendered incorrectly.
Issues Fixed
Fixes #19338