Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[net9.0] Merge main into net9.0 (take 3) #24822

Open
wants to merge 48 commits into
base: net9.0
Choose a base branch
from

Conversation

mattleibow
Copy link
Member

Description of Change

Yup, this again.

filipnavara and others added 30 commits July 5, 2024 00:39
* Fix SafeArea adjustments

* - fix
* Fix shadow consistency on Android and iOS

* Update test screenshots
* [Android & iOS] dialog theme change on changing UserAppTheme

* Update Application.cs
* Added note to ignore device tests

* Update note for new devs, Added section on VerifyScreenshots, Explanation about AutomationId

* Removed Fixture Setup/Teardown

* Moved paragraphs around and added new subheadings to make it easier to read. Used correct formatting for class names. Removed GalleryPage content. Removed some redundant content.

* Added note about FailsOn attribute, elaborated on DeviceTests note

* Fixed spelling errors

* Alternate word

* Added back the bit about GalleryPage

* Fixed incorrect link for DeviceTests, added bit about Issue text

* Redid intro

* Added screenshots to the VerifyScreenshots section

* Removed section

* Added info about logging

* Fixed screenshot tags

* One more tag fix

* Fixed spelling, added some syntax formatting

* Addressed comments

* Changed links to permalinks

* Added pic of failed test screenshot
…dateMinimumHeight` (#16573)

* Null guard

* Update ShellFlyoutTemplatedContentRenderer.cs

* Update ShellFlyoutTemplatedContentRenderer.cs

---------

Co-authored-by: Shane Neuville <[email protected]>
…t Set to End (#24485)

* fix-24405-Fixed-Entry-Text-Alignment-Issue

* Fix-24405-Removed local variable and added old comment.

* fix-24405-Testcase sample updated.

* Fix-24405-Test case changes committed.

* fix-24405-Updated new logic.

* fix-24405-Test script changes committed.

* fix-24405-Modified script and sample files.

* fix-24405-Modified test sample code.

* Fix-24405-Snapshots added for windows, iOS and Android.

* Fix-24405-Updated Testscript method name.
…24495)

* Improve Android device type check to use screen size

For Android visual tests, they should be run with the right
device image (currently a Nexus 5X API 30). However,
there's no easy way to check the device type for Appium.
The check that was there before works on CI
since the DEVICE_SKIN environment variable is set there
(set by the android.cake script). And it can work locally if
folks run android.cake then launch VS from that console
session to get the env variable - but it doesn't work if VS
is run separately (normal case).

So update this with a different check. Getting the actual
Android device type requires using adb. We might eventually
do that, but for now just use a screen size check as a proxy
for the device type. Also update the failure message to give
good instructions.

* Add a "uitest-prepare" target to android.cake

uitest-prepare will build the test app, launch
the emulator, and deploy the test app. But
it won't actually run any tests.

* Validate that JAVA_HOME is set

Also display the Android image name

* Check Android device capabilties for a match

* Add uitest-prepare target for ios.cake to match android
* Improve performance and stability of `BindableLayout`
Fixes #23135
Fixes #10918

* Remove `IDispatcher` from `BindableLayout` enhancements

* Fix empty view not removed when adding an item on an empty observable collection

* Adjust MemoryTests to account for the improved `BindableLayout` behavior
* Fix border lagging and unwanted animations on iOS

* Update src/Core/src/Platform/iOS/StrokeExtensions.cs

Co-authored-by: MartyIX <[email protected]>

* Add some control on the test case

* Ensure every CALayer used by MAUI does not use animations.

---------

Co-authored-by: MartyIX <[email protected]>
* [Android] invalidate shadows on parent's size change

* Update WrapperView.cs

* Added snapshots
)

* Fix layout when MinimumWidth/HeightRequest is removed on Windows

* Request smaller sizes to see if it fixes tests

* Use AssertionExtensions.AssertEventually to test layout values
…40909.1 (#24673)

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 9.0.0-prerelease.24420.3 -> To Version 10.0.0-prerelease.24459.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update script to generate PublicAPIs

* Update mark-shipped.ps1

* Update mark-shipped.ps1
* Don't invalidate SuperView if not connected to Window

* - fix test to run better on all platforms
#23442)

### Description of Change

Fixes an issue where scrolling of SwipeView's parent is disabled during
swipe but not reenabled when the swipe is cancelled by manually moving
the touch below the threshold.

### Issues Fixed

Fixes #23441 
Fixes #16856
#24585)

* Split off DatePicker.HandlerDoesNotLeak into its own UI test.

* Changed RunMemoryTest to take in INavigation instead of NavigationPage, renamed Issue24147 to MemoryTests and changed it to take in Text from Entry to determine which Handler to use, Removed Issue22072 as that's now in MemoryTests

* Renamed Issue24147 in Tests.Shared to MemoryTests, added methods to check DatePicker and WebView. Added automationids in HostApp MemoryTests
PureWeen and others added 18 commits September 9, 2024 23:36
* Make sure that Navigation Pages fill the screen

* Update Issue23484.cs

* - add arrange back in
* 899474 :[Android]Editor/Entry controls don't raise Completed event

* Test cases update commit

* commit for UI changes

* Commit for platform definition

* commit for review changes

* 899474: Image Added

* Update Issue9796.cs

* Update Issue9796.cs

* Review changes for Testcases

* Image commit

* Update Issue9796.cs

* 899474:Removing the entry codes

* Update EntryHandler.Android.cs

* Changes for test case

* Update Issue9796.xaml.cs

* Review changes

* commit for review changes

* Update Issue9796.cs

* Update Issue9796.cs
Context: 7efca8e
Context: xamarin/Xamarin.Forms#7407

For Debug builds, .NET MAUI runs XamlC in a "ValidateOnly" mode, which
avoids writing `.dll` files at the end. This way, we get faster
builds, but still emit the same errors and warnings that would be
emitted in `Release` mode.

Right now, the `ValidateOnly` flag is only checked at the end of the
process to skip writing files. I looked for some places taking time,
such as:

    36.30ms (1.1%) microsoft.maui.controls.build.tasks!Microsoft.Maui.Controls.Build.Tasks.NodeILExtensions+<PushServiceProvider>d__12.MoveNext()
    20.20ms (0.6%) microsoft.maui.controls.build.tasks!Microsoft.Maui.Controls.Build.Tasks.NodeILExtensions+<PushParentObjectsArray>d__9.MoveNext()
     1.21ms (0.0%) microsoft.maui.controls.build.tasks!Microsoft.Maui.Controls.Build.Tasks.NodeILExtensions.PushXmlLineInfo(class Microsoft.Maui.Controls.Xaml.INode,class Microsoft.Maui.Controls.Build.Tasks.ILContext)

And added checks to just return early in these methods.

With this change in-place, an incremental build of a `dotnet new maui`
project template:

    Before:
    1704 ms  XamlCTask                                  4 calls
    After:
    1402 ms  XamlCTask                                  4 calls

This probably saves a little less than 100ms per call, but in this
example it is running once per platform. This improvement probably
will help even more for larger projects with many XAML files.
* [C] Allow OnIdiom/OnPlatform to return a Binding

- fixes #19388
- fixes #18697
- fixes #22877
- closes #23798
- closes #23272

and some others

* fix runtime cast

- fixes #24500
- fixes #16725
* Committed the changes of the issue

* properly fixed the Object disposed exception

* Added the proper name of test case

* Removing the unneccesary space

* fix-15196-Removed the Dispose method.

* fix-15196-Modified and removed the changes in test case and sample.

---------

Co-authored-by: AhamedAliNishad <[email protected]>
…hen using ItemsLayout with a Footer. (#24564)

* fix added for collectionView single item alignment with footer,

* Test sample changes.

* Modified the automation sample.

* Added automation images.

* Added comments.
…ce (#24699)

* Ensure disconnected ItemsViewHandler doesn't hold onto the items source

* Update CarouselViewTests.cs
* Fixed - 22452 - ios Shell

* Added Test case

* Modified test case file

* Modified test case

* Added images for test case

* Modified test case file

* Modified test cases

* Modified test case

* Modified test case

* Added image for test case
* Clear out prototype cell which changing ItemSource

* Update ListViewTests.cs

* Update ListViewTests.cs
* [C] Add ImageSource as LogicalChildren of MenuItem

- fixes #20508

* -fixes #23201 as well

* well, it fixes another one too
…40916.1 (#24785)

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 10.0.0-prerelease.24459.1 -> To Version 10.0.0-prerelease.24466.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
# Conflicts:
#	eng/Version.Details.xml
#	eng/Versions.props
#	eng/devices/ios.cake
#	src/Controls/src/Core/BindableObject.cs
#	src/Controls/src/Core/Handlers/Items/CarouselViewHandler.Windows.cs
#	src/Controls/src/Core/PublicAPI/net-android/PublicAPI.Unshipped.txt
#	src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt
#	src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt
#	src/Controls/src/Core/PublicAPI/net-tizen/PublicAPI.Unshipped.txt
#	src/Controls/src/Core/PublicAPI/net-windows/PublicAPI.Unshipped.txt
#	src/Controls/src/Core/PublicAPI/net/PublicAPI.Unshipped.txt
#	src/Controls/src/Core/PublicAPI/netstandard/PublicAPI.Unshipped.txt
#	src/Controls/src/Xaml/PublicAPI/net-android/PublicAPI.Unshipped.txt
#	src/Controls/src/Xaml/PublicAPI/net-ios/PublicAPI.Unshipped.txt
#	src/Controls/src/Xaml/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt
#	src/Controls/src/Xaml/PublicAPI/net-tizen/PublicAPI.Unshipped.txt
#	src/Controls/src/Xaml/PublicAPI/net-windows/PublicAPI.Unshipped.txt
#	src/Controls/src/Xaml/PublicAPI/net/PublicAPI.Unshipped.txt
#	src/Controls/src/Xaml/PublicAPI/netstandard/PublicAPI.Unshipped.txt
#	src/Core/src/Handlers/Application/ApplicationHandler.Android.cs
#	src/Core/src/Handlers/Application/ApplicationHandler.cs
#	src/Core/src/Platform/iOS/LabelExtensions.cs
#	src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt
#	src/Core/src/PublicAPI/net-ios/PublicAPI.Unshipped.txt
#	src/Core/src/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt
#	src/Core/src/PublicAPI/net-tizen/PublicAPI.Unshipped.txt
#	src/Core/src/PublicAPI/net-windows/PublicAPI.Unshipped.txt
#	src/Core/src/PublicAPI/net/PublicAPI.Unshipped.txt
#	src/Core/src/PublicAPI/netstandard/PublicAPI.Unshipped.txt
#	src/Core/src/PublicAPI/netstandard2.0/PublicAPI.Unshipped.txt
#	src/Essentials/src/HapticFeedback/HapticFeedback.ios.cs
#	src/Essentials/src/PublicAPI/net-android/PublicAPI.Unshipped.txt
#	src/Essentials/src/PublicAPI/net-ios/PublicAPI.Unshipped.txt
#	src/Essentials/src/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt
#	src/Essentials/src/PublicAPI/net-tizen/PublicAPI.Unshipped.txt
#	src/Essentials/src/PublicAPI/net-windows/PublicAPI.Unshipped.txt
#	src/Essentials/src/PublicAPI/net/PublicAPI.Unshipped.txt
#	src/Essentials/src/PublicAPI/netstandard/PublicAPI.Unshipped.txt
#	src/Essentials/src/WebAuthenticator/WebAuthenticator.ios.tvos.cs
@mattleibow mattleibow requested a review from a team as a code owner September 18, 2024 17:16
@mattleibow mattleibow changed the title Merge main into net9.0 [net9.0] Merge main into net9.0 Sep 18, 2024
@mattleibow mattleibow changed the title [net9.0] Merge main into net9.0 [net9.0] Merge main into net9.0 (take 3) Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.