Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed NavigationPage Title property #24781

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Vignesh-SF3580
Copy link
Contributor

@Vignesh-SF3580 Vignesh-SF3580 commented Sep 16, 2024

Root Cause

The issue occurred because the title was being updated based on the current page in the NavigationPage, which prevented the NavigationPage's title from being updated correctly.

Description of Change

The fix ensures that the NavigationPage's title is now updated when it is not null, so the correct title is always displayed.

Validated the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Issues Fixed

Fixes #19859

Screenshots

Before
image

After
image

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Sep 16, 2024
Copy link
Contributor

Hey there @Vignesh-SF3580! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@Vignesh-SF3580 Vignesh-SF3580 marked this pull request as ready for review September 17, 2024 16:36
@Vignesh-SF3580 Vignesh-SF3580 requested a review from a team as a code owner September 17, 2024 16:36
@jfversluis
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-navigation NavigationPage community ✨ Community Contribution platform/iOS 🍎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NavigationPage: BarBackgroundColor, BarTextColor and Title not updating
4 participants