[Localization] Remove check not allowing translations to run on net9.0 #24724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did we got anything for main? translations only happen on devdiv, having that code shouldn't t be the issue |
Yeah it is being run in main right now: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10209378&view=logs&s=266d6c29-b55e-56e1-41c4-d0d9dc0f16a7 |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s), but failed to run 1 pipeline(s). |
rmarinho
requested changes
Sep 13, 2024
The variable of |
tj-devel709
force-pushed
the
dev/TJ/RestoreLocalization_2
branch
from
a4c4c74
to
c555c0c
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s), but failed to run 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
In the net9.0 branch, the translations section is not being applied.
- ${{ if eq(variables['System.TeamProject'], 'devdiv') }}:being false caused the localization templates not to be run. I'm not sure if we need to replace this with something else but I think it should work as this PR has it since that templates all have their own checks on whether to run.Issues Fixed
Fixes #