[iOS] Custom font icon is not rendered in a shell tabbar tab #24721
+155
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
added
platform/iOS 🍎
area-controls-shell
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
What happens if the theme changes at runtime? |
|
@mattleibow We have ensured that runtime theme changes and specific style settings work as expected. In the dark theme, the icon color will be updated based on the title text color.
|
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Duplicate of #22437 |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Whoops lets see which of those PRs we should take in for this and coordinate! Thanks @kubaflo ! |
|
Sure thing! However, please have in mind who was first this time 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RootCause
The custom font images used for icons in the ShellTabBar are being generated with a default color(white) in ImageSourceExtensions. However, since the TabBar background color is also white, the icons are not properly visible.
Description of Change
Modified the rendering mode as Automatic which allows the icon color and selection color of the icon in the TabBar to adjust dynamically based on the current theme or selected state.
Validated the behaviour in the following platforms
Issues Fixed
Fixes #8244
Fixes #22032
Fixes #12250
Fixes #20866
Fixes #23174
Fixes #8244