Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NavigationBar properties not updating - fix #23076

Merged
merged 4 commits into from
Aug 14, 2024
Merged

NavigationBar properties not updating - fix #23076

merged 4 commits into from
Aug 14, 2024

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Jun 15, 2024 •
edited
Loading

Issues Fixed

Fixes #22899
Fixes #23195
Fixes #11790

@kubaflo kubaflo requested a review from a team as a code owner June 15, 2024 15:12
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jun 15, 2024
@PureWeen PureWeen added the area-navigation NavigationPage label Jun 20, 2024
@PureWeen
Copy link
Member

PureWeen commented Jun 20, 2024 •
edited by jfversluis
Loading

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@kubaflo kubaflo changed the title Title not updated after OnAppearing for TabbedPage - fix NavigationBar properties not updating - fix Jun 26, 2024
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jfversluis
Copy link
Member

Looks like tests might be failing? Do we need to update the snapshots here?

@kubaflo
Copy link
Contributor Author

kubaflo commented Aug 9, 2024 •
edited
Loading

Should work now, but we still need to grap snapshots once they are be generated

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@kubaflo
Copy link
Contributor Author

kubaflo commented Aug 10, 2024

@jfversluis snapshots are ready

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jfversluis jfversluis self-assigned this Aug 10, 2024
@PureWeen PureWeen merged commit fa9e370 into dotnet:main Aug 14, 2024
97 checks passed
@samhouts samhouts added fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-net8.0-nightly This may be available in a nightly release! labels Aug 27, 2024
@marcojak
Copy link

I think this is causing a crash, precisely at NavigationPageToolbar.cs:line 210.

This happens when inside the OnAppearing method I try to set
(page.Detail as NavigationPage).BarBackgroundColor = ...

where page is a FlyoutPage.

This doesn't crash in the previous version of MAUI

@samhouts samhouts added fixed-in-9.0.0-rc.1.24453.9 fixed-in-8.0.90 and removed fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-net8.0-nightly This may be available in a nightly release! labels Sep 20, 2024
@samhouts samhouts added this to the .NET 8 SR9 milestone Sep 20, 2024
@MitchBomcanhao
Copy link

I think this is causing a crash, precisely at NavigationPageToolbar.cs:line 210.

This happens when inside the OnAppearing method I try to set (page.Detail as NavigationPage).BarBackgroundColor = ...

where page is a FlyoutPage.

This doesn't crash in the previous version of MAUI

I have the exact same issue, as referenced in #25114

@MitchBomcanhao MitchBomcanhao mentioned this pull request Oct 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PureWeen PureWeen PureWeen approved these changes

@jfversluis jfversluis jfversluis approved these changes

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz jsuarezruiz is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees

@jfversluis jfversluis

Labels
area-navigation NavigationPage community ✨ Community Contribution fixed-in-8.0.90 fixed-in-9.0.0-rc.1.24453.9
Projects
MAUI SDK Ongoing
Status: Done
Milestone
.NET 8 SR9
6 participants
@kubaflo @PureWeen @jfversluis @marcojak @MitchBomcanhao @samhouts