Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Clean all yaml in the pipelines of warnings and errors and add a workflow to validate the yaml used. #21345

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

mandel-macaque
Copy link
Member

@mandel-macaque mandel-macaque commented Mar 20, 2024

Description of Change

This PR is better reviewed file by files since it is a large one. The PR does the following:

  1. Creates a workflow that will execute yamllint on the devops yaml files. The workflow will add a human readable and GitHub formatted comment with all the warnings and errors found in the PR, that way no new errors will be introduced.
  2. Cleans all the yamllint warnings and errors of the pipelines present in the source.

This will help us keep the pipeline code clean. For anyone working on the pipelines, you can install locally yamllint and run it or add one of its editor plugins: https://yamllint.readthedocs.io/en/stable/text_editors.html

dalexsoto
dalexsoto previously approved these changes Mar 20, 2024
@mandel-macaque
Copy link
Member Author

@rmarinho I'm using an action for the comment which might have not been approved, should we move to a curl? Although its a lot more work

@rmarinho
Copy link
Member

I think we have permissions to use other actions

.github/workflows/yamllint.yml Outdated Show resolved Hide resolved
.github/workflows/yamllint.yml Outdated Show resolved Hide resolved
@mandel-macaque
Copy link
Member Author

I think we have permissions to use other actions

@rmarinho If you click on actions you'll see that it did not run. I suppose it needs an update in the settings.

@Eilon Eilon added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Mar 29, 2024
@jsuarezruiz
Copy link
Contributor

@mandel-macaque Thanks for the effort and sorry for the delay. Could you rebase it?

@jsuarezruiz jsuarezruiz added the stale Indicates a stale issue/pr and will be closed soon label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions stale Indicates a stale issue/pr and will be closed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants