Skip to content

Conversation

@ViktorHofer
Copy link
Member

Fixes #19209

Description

Fixes # (issue, if applicable)

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/release-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

@github-actions
Copy link
Contributor

✅ No release notes required

@ViktorHofer
Copy link
Member Author

@mmitche FYI, that fixes the exit code=0 when there's a failure in fsharp building inside the VMR

@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Jan 13, 2026
@T-Gro T-Gro enabled auto-merge (squash) January 13, 2026 12:29
@T-Gro T-Gro merged commit 722fd6b into main Jan 13, 2026
40 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in F# Compiler and Tooling Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Fsharp's build scripts don't return a non zero exit code when there's a failure

3 participants