Skip to content

[WIP] Investigation: Object expressions in struct types generating invalid IL with byref fields #19070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 32 commits into
base: main
Choose a base branch
from
+661 −2
Draft

[WIP] Investigation: Object expressions in struct types generating invalid IL with byref fields #19070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
6a4733e
Initial plan
Copilot Nov 11, 2025
b8e8f28
Fix object expressions in struct types generating invalid IL with byr…
Copilot Nov 11, 2025
0616707
Add IsInstanceMember check to only transform instance members of structs
Copilot Nov 11, 2025
de89a91
Add interface check to prevent transformation for pure interface impl…
Copilot Nov 11, 2025
086f23f
Refactor struct object expression fix to CheckExpressionsOps with cle…
Copilot Nov 11, 2025
de69a3c
Fix type inference issue by removing explicit generic type annotation
Copilot Nov 11, 2025
7b92bd5
Temporarily disable struct member extraction transformation
Copilot Dec 31, 2025
e76bb66
Implement proper context detection using env.eFamilyType
Copilot Dec 31, 2025
3d761aa
Fix TcGlobals type reference to use fully qualified name
Copilot Dec 31, 2025
dda20a5
Merge branch 'main' into copilot/fix-invalid-il-byref-fields
T-Gro Jan 2, 2026
8f033f7
Apply patch from /run fantomas
actions-user Jan 2, 2026
068c876
Fix test code and remove incorrect baseValOpt check
Copilot Jan 2, 2026
a4bd40a
Remove unused baseValOpt parameter
Copilot Jan 2, 2026
67ee4fd
Apply patch from /run fantomas
actions-user Jan 2, 2026
9e01e21
Remove IsInstanceMember filter to capture all struct values
Copilot Jan 2, 2026
192f5cc
Fix context detection by analyzing free variables instead of env.eFam…
Copilot Jan 2, 2026
1660987
Broaden filter to include variables without DeclaringEntity
Copilot Jan 2, 2026
782c5db
Add ctorCall remapping and clean up debug output
Copilot Jan 2, 2026
51a0aa0
Fix syntax error - remove incomplete debug code
Copilot Jan 2, 2026
9150cff
Fix false positive byref errors by adding proper context guards
Copilot Jan 5, 2026
44092f4
Fix IsParameter error - use IsMemberOrModuleBinding check instead
Copilot Jan 5, 2026
e75f57b
Fix filter to capture struct constructor parameters correctly
Copilot Jan 5, 2026
80b0fb7
Fix enclosingStructTyconRefOpt detection - capture BEFORE EnterFamily…
Copilot Jan 6, 2026
689feb2
Simplify filter to capture struct constructor parameters correctly
Copilot Jan 6, 2026
7623be8
Remove interface-only guard - interfaces also need transformation
Copilot Jan 6, 2026
ba60ec5
Remove debug logging - all tests passing
Copilot Jan 6, 2026
ab9e0f5
Remove unused isInterfaceTy parameter
Copilot Jan 6, 2026
d1cc465
Fix false positive in static members - only transform instance member…
Copilot Jan 7, 2026
e985923
Revert object expression transformation to fix seqcore.fs regression
Copilot Jan 7, 2026
dd6a0c1
REVERT: Remove all object expression transformation code
Copilot Jan 7, 2026
fc8bfdc
Add Hypothesis 11: Confirm tests properly detect the bug
Copilot Jan 7, 2026
27509e5
fix
T-Gro Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading