Skip to content

Old IncrementalBuilder: Fix cancellation token not passed to tcExtras#18279

Closed
majocha wants to merge 1 commit intodotnet:mainfrom
majocha:tcextras-cancellation
Closed

Old IncrementalBuilder: Fix cancellation token not passed to tcExtras#18279
majocha wants to merge 1 commit intodotnet:mainfrom
majocha:tcextras-cancellation

Conversation

@majocha
Copy link
Contributor

@majocha majocha commented Jan 28, 2025

Browsing this code I noticed cancellation token was not passed in one situation. My bad, probably.
Not sure if this improves performance at all or decreases it. Not sure if this still works correctly with this change. I'll install this and test in use.
Old incremental builder unlike Transparent Compiler is opaque, indeed.

@github-actions
Copy link
Contributor

❗ Release notes required

@majocha,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.300.md No release notes found or release notes format is not correct

@majocha majocha force-pushed the tcextras-cancellation branch from a02b830 to c70a23a Compare May 5, 2025 08:41
@majocha majocha closed this May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant