"#if" directive around nullness removed refactored in HashMultiMap#18210
"#if" directive around nullness removed refactored in HashMultiMap#18210progressive-galib wants to merge 2 commits intodotnet:mainfrom
Conversation
from src/Compiler/Utilities/HashMultiMap.fs and fsi Related: dotnet#18061 (partially addresses) <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> - [x] Release notes entry updated: in `docs/release-notes/.FSharp.Compiler.Service/9.0.200.md`,
❗ Release notes requiredCaution No release notes found for the changed paths (see table below). Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format. The following format is recommended for this repository:
If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request. You can open this PR in browser to add release notes: open in github.dev
|
|
@progressive-galib |
| #endif | ||
| > = | ||
| { tbl: HashMultiMap<'T, int> // This should be "Dictionary" | ||
| { tbl: HashMultiMap<'T, int when 'T: not null> // This should be "Dictionary" |
There was a problem hiding this comment.
Hi @progressive-galib - this won't compile :)
'T is already defined and constrained up above, this should hold for tbl - I don't think changes here are needed.
|
Closing due to conflicts accumulated since this was started. Feel free to restart later. |
4 participants
Description
"#if" directive around nullness removed refactored in HashMultiMap src/Compiler/Utilities/HashMultiMap.fs and fsi
Related: #18061 (partially addresses)
reopened due to closing of #18202 by mistake by force pushing.