Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose SQLite VFS option in connection string #34864

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Expose SQLite VFS option in connection string #34864

merged 3 commits into from
Dec 3, 2024

Conversation

arontsang
Copy link
Contributor

Simple PR to expose the VFS option in the connection string.

@arontsang arontsang requested a review from wtgodbe as a code owner October 9, 2024 13:28
@arontsang arontsang changed the base branch from release/8.0-rc2 to release/8.0 October 9, 2024 13:29
@arontsang arontsang force-pushed the master branch 2 times, most recently from db442e9 to 27747aa Compare October 9, 2024 13:35
@cincuranet cincuranet self-requested a review October 9, 2024 21:21
@cincuranet
Copy link
Contributor

@arontsang This needs to be updated to target main branch.

@arontsang arontsang changed the base branch from release/8.0 to main October 10, 2024 13:48
@arontsang arontsang force-pushed the master branch 2 times, most recently from 0bd8307 to cfd4ada Compare October 11, 2024 19:53
@arontsang
Copy link
Contributor Author

@cincuranet Updated

cincuranet
cincuranet reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@cincuranet cincuranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small questions/comments. Otherwise LGTM.

src/Microsoft.Data.Sqlite.Core/SqliteConnectionStringBuilder.cs Outdated Show resolved Hide resolved
src/Microsoft.Data.Sqlite.Core/SqliteConnectionStringBuilder.cs Outdated Show resolved Hide resolved
src/Microsoft.Data.Sqlite.Core/SqliteConnectionStringBuilder.cs Outdated Show resolved Hide resolved
cincuranet
cincuranet reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@cincuranet cincuranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's no response from the author. But I still think this is a good feature and PR, so I'll take over and finish it.

src/Microsoft.Data.Sqlite.Core/SqliteConnectionStringBuilder.cs Outdated Show resolved Hide resolved
src/Microsoft.Data.Sqlite.Core/SqliteConnectionStringBuilder.cs Outdated Show resolved Hide resolved
src/Microsoft.Data.Sqlite.Core/SqliteConnectionStringBuilder.cs Outdated Show resolved Hide resolved
@cincuranet cincuranet requested a review from a team as a code owner December 3, 2024 09:55
@cincuranet cincuranet merged commit aed754c into dotnet:main Dec 3, 2024
7 checks passed
cincuranet added a commit to cincuranet/docs that referenced this pull request Dec 3, 2024
@cincuranet
Add documentation for VFS introduced in dotnet/efcore#34864.
17e8268
cincuranet added a commit to dotnet/docs that referenced this pull request Dec 5, 2024
@cincuranet
Add documentation for VFS introduced in dotnet/efcore#34864. (#43833)
8108d6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cincuranet cincuranet cincuranet approved these changes

@wtgodbe wtgodbe Awaiting requested review from wtgodbe

Assignees

@cincuranet cincuranet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arontsang @cincuranet