-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solves the problem of getting project MSBuild information #34574
base: main
Are you sure you want to change the base?
Solves the problem of getting project MSBuild information #34574
Conversation
- Refactor MSBuild integration to remove the need for EntityFrameworkCore.targets and GetEFProjectMetadata target. Fixes dotnet#23853
Hi @AndriySvyryd. Do you need anything from me on this PR? |
Ideally the PR should include tests, but we currently don't have the infrastructure for this. Once #33136 is done I'll take a look at the PR. It was submitted too late for 9.0 anyway, so there's no rush. |
I looked for the tests and couldn't find them. You can reach out to someone at MSBuild to check this. This can easily go to .NET 8.0, because the SDK supports it. I've been using this for a while. |
Fixes #32113 |
Err wait, not quite. Remove |
Was it, for sure, used only for this purpose? If it was, we should remove it. |
Yes. It just told us where to copy the MSBuild file |
Removed! |
This PR replaces the
GetEFProjectMetadata
target in EntityFrameworkCore.targets with Evaluate items and properties and display results of targets.Fixes #23853
Fixes #30725