Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Associate the DatabaseRoot with the scoped options instance and not the singleton options. #34477

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Associate the DatabaseRoot with the scoped options instance and not the singleton options. #34477

wants to merge 1 commit into from
+204 −196

Conversation

koenigst
Copy link
Contributor

  • Remove the DatabaseRoot from the InMemoryOptionsExtension service provider equality condition.
  • Remove the DatabaseRoot from the InMemorySingletonOptions.
  • Resolve the IInMemoryStore in a scoped service (IInMemoryStoreProvider) instead of a singleton service (IInMemoryStoreCache).
  • Fall back to the DatabaseRoot stored in a singleton service (IInMemoryDatabaseRootCache) if the options does not specify one.

Fixes #34476

@koenigst
Associate the DatabaseRoot with the scoped options instance and not t…
7020187 
…he singleton options.

- Remove the DatabaseRoot from the InMemoryOptionsExtension service provider equality condition.
- Remove the DatabaseRoot from the InMemorySingletonOptions.
- Resolve the IInMemoryStore in a scoped service (IInMemoryStoreProvider) instead of a singleton service (IInMemoryStoreCache).
- Fall back to the DatabaseRoot stored in a singleton service (IInMemoryDatabaseRootCache) if the options does not specify one.

Fixes dotnet#34476
@koenigst
Copy link
Contributor Author

@dotnet-policy-service agree company="Zühlke Engineering AG"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AndriySvyryd AndriySvyryd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Model is rebuilt when the database root changes
2 participants
@koenigst @AndriySvyryd