-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Add missing analyzers docs #50819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add missing analyzers docs #50819
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds documentation for seven MSTest analyzer rules (MSTEST0056-MSTEST0062) that were missing from the documentation set. These analyzers will be released in MSTest 4.1 (with two from 4.0.0). The documentation follows the established pattern for analyzer rule documentation with frontmatter, property tables, examples, and suppression guidance.
Key changes:
- Adds 7 new analyzer rule documentation files with comprehensive examples and guidance
- Updates the TOC to include navigation entries for the new rules
- Extends the usage-rules.md summary table with descriptions of the new analyzers
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/navigate/devops-testing/toc.yml | Adds navigation entries for MSTEST0056-MSTEST0062 |
| docs/core/testing/mstest-analyzers/usage-rules.md | Updates the analyzer summary table with 7 new rule entries |
| docs/core/testing/mstest-analyzers/mstest0056.md | Documents the DisplayName property usage rule |
| docs/core/testing/mstest-analyzers/mstest0057.md | Documents the source information propagation rule for custom attributes |
| docs/core/testing/mstest-analyzers/mstest0058.md | Documents avoiding assertions in catch blocks |
| docs/core/testing/mstest-analyzers/mstest0059.md | Documents the Parallelize/DoNotParallelize conflict rule |
| docs/core/testing/mstest-analyzers/mstest0060.md | Documents avoiding duplicate test method attributes |
| docs/core/testing/mstest-analyzers/mstest0061.md | Documents using OSCondition attribute instead of runtime checks |
| docs/core/testing/mstest-analyzers/mstest0062.md | Documents avoiding out/ref parameters in test methods |
Co-authored-by: Genevieve Warren <[email protected]>
|
@gewarren thank you for your review. I have left 2 comments on parts where I would really like your input. |
Summary
Add the 2 missing shipped analyzers docs + all the rules we will soon be shipping (MSTest 4.1)
cc @Youssef1313
Internal previews
catchblocks