Add registry search for upgrade policy keys #57952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-infrastructure
joeloff
reviewed
Sep 18, 2024
joeloff
approved these changes
Sep 18, 2024
joeloff
approved these changes
Sep 18, 2024
wtgodbe
added
Servicing-consider
wtgodbe
added a commit
that referenced
this pull request
Sep 26, 2024
* Add registry search for upgrade policy keys * SharedFx bundle too * Add util extension * Another fix
wtgodbe
added a commit
that referenced
this pull request
Oct 7, 2024
* Add registry search for upgrade policy keys * SharedFx bundle too * Add util extension * Another fix
wtgodbe
added a commit
that referenced
this pull request
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2541983&view=results
Aspnetcore version of dotnet/arcade#15048
Description
Add registry search operations to Aspnetcore installer bundles. The search operation will check for a global and version specific registry key. The version specific key takes precedence when present.
This is related to a customer request and part of a larger change.
Unlike the runtime and desktop runtime, Aspnetcore needs to explicitly pull in the additional source file.
Risk
Medium/Low - this change modifies how bundles behave when upgrading. It is based off a modified copy of wixstdba (bootstrapper and UI layer) with changes to Burn (setup engine) and a copy of WiX v3 built from source.
Testing
We've been testing the change for a while now. Verified against a private build of Aspnetcore. After installing preview7, followed by a new RC2 build, both runtimes remain present, and the RunOnce key for the removal is present for preview7.