Added overload of AddConnectionString using the builder pattern to make it more approachable#8251
Merged
Added overload of AddConnectionString using the builder pattern to make it more approachable#8251
Conversation
…d improve documentation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an overload for AddConnectionString that leverages the builder pattern, making the API more approachable for constructing connection strings.
- Introduces a new overload method with appropriate XML documentation and example code.
- Updates the test suite to reflect the new API and corrects a typo in a test method name.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Aspire.Hosting/ConnectionStringBuilderExtensions.cs | Adds the overload and XML comments using the builder pattern to construct connection strings. |
| tests/Aspire.Hosting.Tests/WithReferenceTests.cs | Fixes a test method name typo and introduces a new test for the builder overload. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…nd update tests for consistency
davidfowl
commented
Mar 22, 2025
mitchdenny
approved these changes
Mar 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added overload of
AddConnectionStringusing the builder pattern to make it more approachableChecklist
breaking-changetemplate):doc-ideatemplate):