Fix aspire add in polyglot scenarios without .NET SDK#14817
Merged
davidfowl merged 1 commit intorelease/13.2from Mar 1, 2026
Merged
Fix aspire add in polyglot scenarios without .NET SDK#14817davidfowl merged 1 commit intorelease/13.2from
davidfowl merged 1 commit intorelease/13.2from
Conversation
Remove the SDK availability gate from NuGetPackagePrefetcher that prevented package discovery when the .NET SDK was not installed. This caused 'aspire add' to fail with 'No integration packages were found' in polyglot (TypeScript/Python) scenarios. Fixes #14702 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14817Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14817" |
Member
Author
|
We'll need a non interactive version of |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the .NET SDK availability gate in the CLI’s NuGet package prefetch background service so aspire add can discover integration packages in polyglot scenarios where the .NET SDK is not installed (per #14702).
Changes:
- Drop
IDotNetSdkInstallerfromNuGetPackagePrefetcherand remove the early return when the SDK is unavailable. - Always allow template/CLI package prefetch to proceed (best-effort) regardless of SDK presence.
davidfowl
commented
Mar 1, 2026
Contributor
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #22532423176 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
aspire addfails with "No integration packages were found" in polyglot (TypeScript/Python/etc.) scenarios because theNuGetPackagePrefetcherbackground service skips package fetching when it detects the .NET SDK is not installed.The prefetcher had an SDK availability gate that was unnecessary — the CLI always uses its bundled NuGet client for package discovery, not
dotnet package search. Removing the gate allows package prefetching to work regardless of SDK availability.Fixes #14702
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: