Don't use client factory in WithRedisInsights. (#6067)

dotnet · Oct 3, 2024 · dfdc244 · dfdc244
1 parent f79f3a9
commit dfdc244
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 4 deletions.
diff --git a/playground/Redis/Redis.AppHost/appsettings.Development.json b/playground/Redis/Redis.AppHost/appsettings.Development.json
@@ -0,0 +1,8 @@
+{
+  "Logging": {
+    "LogLevel": {
+      "Default": "Information",
+      "Microsoft.AspNetCore": "Warning"
+    }
+  }
+}
diff --git a/playground/Redis/Redis.AppHost/appsettings.json b/playground/Redis/Redis.AppHost/appsettings.json
@@ -0,0 +1,9 @@
+{
+  "Logging": {
+    "LogLevel": {
+      "Default": "Information",
+      "Microsoft.AspNetCore": "Warning",
+      "Aspire.Hosting.Dcp": "Warning"
+    }
+  }
+}
diff --git a/src/Aspire.Hosting.Redis/RedisBuilderExtensions.cs b/src/Aspire.Hosting.Redis/RedisBuilderExtensions.cs
@@ -145,7 +145,6 @@ public static IResourceBuilder<RedisResource> WithRedisInsight(this IResourceBui
         }
         else
         {
-            builder.ApplicationBuilder.Services.AddHttpClient();
             containerName ??= $"{builder.Resource.Name}-insight";
 
             var resource = new RedisInsightResource(containerName);
@@ -165,12 +164,10 @@ public static IResourceBuilder<RedisResource> WithRedisInsight(this IResourceBui
                     return;
                 }
 
-                var httpClientFactory = e.Services.GetRequiredService<IHttpClientFactory>();
-
                 var redisInsightResource = builder.ApplicationBuilder.Resources.OfType<RedisInsightResource>().Single();
                 var insightEndpoint = redisInsightResource.PrimaryEndpoint;
 
-                var client = httpClientFactory.CreateClient();
+                using var client = new HttpClient();
                 client.BaseAddress = new Uri($"{insightEndpoint.Scheme}://{insightEndpoint.Host}:{insightEndpoint.Port}");
 
                 var rls = e.Services.GetRequiredService<ResourceLoggerService>();