Conversation
jonathanpeppers
approved these changes
Mar 25, 2025
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
Overall looks good, it makes sense for this lane to show up here:
Comment on lines
-156
to
-160
| p.OutputDataReceived += WriteProcessOutputMessage; | ||
| p.ErrorDataReceived += WriteProcessErrorMessage; | ||
|
|
||
| p.BeginOutputReadLine (); | ||
| p.BeginErrorReadLine (); |
Member
There was a problem hiding this comment.
So, was it specifically these lines that made Run() never return on Windows?
Member
Author
There was a problem hiding this comment.
Yeah this seemed to fix things in CI, though I never had this issue when running locally on Windows strangely enough
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new Intel based Windows pool has been configured to run Android
emulator test jobs on. This pool currently has capacity to scale up to
10 agents.
The
StartAndroidEmulatortask and the execution environment for theAcquireAndroidTargettarget have been updated to address issues withemulator launch attempts hanging on these Windows VMs with this
seemingly related output:
A new "Windows > Tests > Debugging" job has been added to the MSBuild
Device tests stage that currently runs all tests in the
DebuggingTestcategory.
Starting with only one new job will allow us to start to scale up on
Windows while monitoring for potential performance/reliabilty issues.