Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

[Windows] Fix DrawImage method #458

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Jun 22, 2022

Fix DrawImage method on Windows

image

@jsuarezruiz
Copy link
Contributor Author

We need this PR as a preliminary step to fix #250

hartez
hartez previously approved these changes Jun 22, 2022
@jonlipsky
Copy link
Contributor

This adds a significant performance and memory hit. The library should be able to re-use the underlying native image representations, especially when you need to do something like tile an image.

@hartez hartez requested review from hartez and jonlipsky and removed request for hartez June 23, 2022 22:51
@hartez hartez dismissed their stale review June 23, 2022 22:53

Lipsky is more qualified.

@jonlipsky
Copy link
Contributor

@hartez @jsuarezruiz This will need a more involved fix. The problem is that with Direct2D you have limitations about using resources between contexts. In some cases, the proposed solution would be acceptable but in most cases it's not acceptable from the aforementioned memory and performance issues.

I should have some time tomorrow to look at a permanent solution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants