-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to .NET 8, re-write, etc. #373
base: main
Are you sure you want to change the base?
Conversation
I have a bunch of similar fixes, updates and rewrites for parts of the app as well. We should try merging / resolving and updating to get this workshop up to date |
What are all the deltas? Perhaps we could do a rapid follow up PR—as I'd hate for perfect to be the enemy of good. Right now, this PR has a ton of changes already. Are your changes local or in a PR already? |
Would we consider porting this all the way to net9.0? The changes should be relatively minor compared to the net8.0 update, but we could make things a little cleaner by using the new built-in |
Not saying that it's a bad idea (in fact, I agree), but I do see value in having the |
We've updated once the version is RTMed. This way people know that if you pull main, you will have the current version. My $0.02 is to have the PR and merge after it's shipped. |
Also: @jglozano and I are teaching this workshop on Sept 8, and I'll be delivering it again on Sept 24 |
Knowing that, I'd argue not to take this PR then as this is not aligned with the save-points and now teaches different things. |
@IEvangelist - I think there ARE new things to teach including interactivity, the new identity model, and I think .NET Aspire should come into the mix eventually My version is sitting at: https://github.com/csharpfritz/BlazingPizzaWorkshop and I presented the workshop through live streams and recorded videos in the series at https://www.youtube.com/watch?v=sWTpxFcHbfY&list=PLdo4fOcmZ0oXv32dOd36UydQYLejKR61R&index=79 |
I rewrote the main app, upgrading to .NET 8. It functions identically as before however, I did take some liberties.
In this PR:
Marker
andPoint
.api
prefix to avoid ambiguous endpoints, and allowing themyorders
page to be renamed asorders
.OnConfiguring
override in thePizzaStoreContext
to express a pizza.db in the local app data folder instead of local to the app running.