Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to .NET 8, re-write, etc. #373

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IEvangelist
Copy link

I rewrote the main app, upgrading to .NET 8. It functions identically as before however, I did take some liberties.

In this PR:

  • Upgraded leaflet to the latest stable version 1.9.4.
  • I used centralized package management for versioning .NET bits.
  • The local storage bits were rewritten using the JS module (export/import) support.
  • I moved some models from the component lib into the shared lib, since they were used in multiple places fixing (and inverting) their dependencies, namely Marker and Point.
  • The orders API was rewritten as a Minimal API with an api prefix to avoid ambiguous endpoints, and allowing the myorders page to be renamed as orders.
  • Used vertical slices where appropriate for Orders, Pizzas, and Notifications:
    • Each have their respective endpoint extension classes and corresponding other bits as needed.
  • Made a few minor style changes.
  • Used OnConfiguring override in the PizzaStoreContext to express a pizza.db in the local app data folder instead of local to the app running.
  • Deleting the existing Server/Client projects.
  • Replaced with the new Blazor Web App approach using Individual Accounts for auth.

@IEvangelist
Copy link
Author

Landing page

image

Register UX

image

Registration confirmation UX

image

Thank you - confirmation UX

image

Login UX

image

Logged in UX

image

Add & Configure Za UX

image

Pizzas in Order UX

image

Review order UX

image

Preparing order UX

image

"Out for delivery UX**

image

Delivered UX

image

Order UX

image

@csharpfritz
Copy link
Collaborator

I have a bunch of similar fixes, updates and rewrites for parts of the app as well. We should try merging / resolving and updating to get this workshop up to date

@IEvangelist
Copy link
Author

I have a bunch of similar fixes, updates and rewrites for parts of the app as well. We should try merging / resolving and updating to get this workshop up to date

What are all the deltas? Perhaps we could do a rapid follow up PR—as I'd hate for perfect to be the enemy of good. Right now, this PR has a ton of changes already. Are your changes local or in a PR already?

@halter73
Copy link

halter73 commented Sep 6, 2024

Would we consider porting this all the way to net9.0? The changes should be relatively minor compared to the net8.0 update, but we could make things a little cleaner by using the new built-in PersistentAuthenticationStateProvider. I understand wanting to have something that targets the LTS release, but I also want to encourage everyone to use the latest release.

@IEvangelist
Copy link
Author

Would we consider porting this all the way to net9.0? The changes should be relatively minor compared to the net8.0 update, but we could make things a little cleaner by using the new built-in PersistentAuthenticationStateProvider. I understand wanting to have something that targets the LTS release, but I also want to encourage everyone to use the latest release.

Not saying that it's a bad idea (in fact, I agree), but I do see value in having the net8.0 bits at the very least in an upstream branch for folks who prefer the LTS version. Then once that's there, we could go to net9.0.

@jglozano
Copy link
Collaborator

jglozano commented Sep 6, 2024

We've updated once the version is RTMed. This way people know that if you pull main, you will have the current version.

My $0.02 is to have the PR and merge after it's shipped.

@csharpfritz
Copy link
Collaborator

Also: @jglozano and I are teaching this workshop on Sept 8, and I'll be delivering it again on Sept 24

@IEvangelist
Copy link
Author

Also: @jglozano and I are teaching this workshop on Sept 8, and I'll be delivering it again on Sept 24

Knowing that, I'd argue not to take this PR then as this is not aligned with the save-points and now teaches different things.

@csharpfritz
Copy link
Collaborator

@IEvangelist - I think there ARE new things to teach including interactivity, the new identity model, and I think .NET Aspire should come into the mix eventually

My version is sitting at: https://github.com/csharpfritz/BlazingPizzaWorkshop and I presented the workshop through live streams and recorded videos in the series at https://www.youtube.com/watch?v=sWTpxFcHbfY&list=PLdo4fOcmZ0oXv32dOd36UydQYLejKR61R&index=79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants