-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Enable TLS for local development with docker compose #1479
base: dev
Are you sure you want to change the base?
Conversation
Hey @mvelosop , yes long time 😊. Thank you for submitting the PR. Will test and update. |
BTW, I forgot to mention that the start procedure changes a bit, because there's the I added the
You also need to create the self-signed certificates, as per the Cheers 😊 |
Thank you for the update @mvelosop and sharing further details 😊 |
Thanks for the info @sughosneo, It should work as long as you:
Cheers 😊 |
Hi @mvelosop, I have performed a quick test of this PR. Couple of things I have noticed.
But after that when I cleaned up all the images and try to rebuild the images again. It throws below error : Am I missing anything ? Thoughts ? Please note, I am yet to test out the entire functionality in details. I will perform further testing and try to capture more information. Thank you. Cheers 😊 |
Well, there was another bug, the last line of Pushing another commit with both fixes now. |
Hi @mvelosop. First, thank you for taking the initiative to add this feature! I tried it out and got an error when running the install-docker-certificate.ps1 file. The error is on line 18 and states, "Copy-Item : Could not find a part of the path". This happens because the repo, in its pristine state, has no "certificates" folder under "src". The fix is to add the following line just before the Copy-Item line: New-Item -ItemType File -Path ....\src\certificates\docker-self-signed.crt -Force This creates the directory along with an empty file which gets overwritten by the Copy-Item command that follows it. |
Hi again @mvelosop. Just a minor typo in the Readme.md file. On line 38, ".yaml" should be ".yml". Thank you! |
Hi @nishanil, @sughosneo
Long time no see 😉
Could take a look at this PR?
Cheers 😊