Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge v1 branch to main #525

Merged
merged 9 commits into from
Aug 30, 2024
Merged

Merge v1 branch to main #525

merged 9 commits into from
Aug 30, 2024

Conversation

jozefizso
Copy link
Collaborator

No description provided.

@jozefizso jozefizso self-assigned this Aug 30, 2024
@jozefizso jozefizso added the documentation Improvements or additions to documentation label Aug 30, 2024
@jozefizso jozefizso merged commit 1a288b6 into main Aug 30, 2024
2 checks passed
@jozefizso jozefizso deleted the v1 branch August 30, 2024 10:51
@jcorreia-forbesadvisor
Copy link

@jozefizso this broke all actions currently pointing to uses: dorny/test-reporter@v1 as branch no longer exists.

Is there another recommended way to access a major version or shouldn't we be doing it at all?

@TheSench
Copy link

The pattern of using v1 for the latest v1.x is common, and is even used by all of the official actions provided by GitHub.

@jozefizso jozefizso restored the v1 branch August 30, 2024 11:06
@jozefizso
Copy link
Collaborator Author

Thanks for point this out, @TheSench. The v1 branch should not been deleted.

@TheSench
Copy link

In other actions, I typically see this managed as a tag instead of a branch. I'm guessing the v1 branch was not marked as a protected branch and was deleted upon merging to main?

@TheSench
Copy link

Thanks for the quick restoration.

@jozefizso
Copy link
Collaborator Author

It's a branch so people can make PRs against it, eg. #517

Yes, it does not have branch protection rules, as I don't have access to repository settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants