Issue 1118 GitHub actions #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dondi
reviewed
Oct 30, 2024
.github/workflows/node.js.yml
Outdated
Comment on lines
27
to
28
| sudo apt-get install -y libcairo2-dev libpango1.0-dev | ||
| libjpeg-dev libgif-dev librsvg2-dev |
There was a problem hiding this comment.
I think this should stay as one line; the error hints that GitHub’s environment is trying to perform the libjpeg-dev line as a command, and that would be due to its being on another line
.github/workflows/node.js.yml
Outdated
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [18.x, 20.x, 22.x] |
There was a problem hiding this comment.
Per our meeting, to simplify things for now, let’s reduce this to just one version until things are more settled
adding necessary ubuntu package
adding the replacement for libjpeg-dev
|
The branch has now passed all the checks and CI testing has been successfully integrated into GitHub Actions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will allow testing (previously Travis /CI) to be shown through Github Actions instead.