Preview button appears only if wiki syntax is enabled #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I'm not sure about this change. While you are right that the comment is really just repeated, it might still be nice for a user to see in the preview that there is actually no formatting. I.e., if you expected that there was some support for formatting and you used that and then you press preview and see that formatting is ignored, you can fix your comment to remove the formatting. |
|
I think there can be no confusion. Wikitext enabled Wikitext disabled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When wiki syntax is disabled, the preview simply repeats the comment.
Therefore the preview button is useless and can be removed from the form.