Tess factor push constant #5383
Open
+124
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doitsujin
force-pushed
the
tess-factor-push-constant
branch
5 times, most recently
from
9761b1f to
7fd3bee
Compare
doitsujin
force-pushed
the
tess-factor-push-constant
branch
from
7fd3bee to
999e427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #5381, hence the draft.
This fixes a regression where changing
d3d11.maxTessFactorwould not do anythig for cached shaders, because we weren't passing the option in as part of the shader key. But it's silly to recompile shaders for something as trivial as this anyway, so let's just use a push constant instead.