Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid exit in entrypoint #30

Merged
merged 1 commit into from
Dec 5, 2021
Merged

avoid exit in entrypoint #30

merged 1 commit into from
Dec 5, 2021

Conversation

AbcSxyZ
Copy link
Contributor

@AbcSxyZ AbcSxyZ commented Dec 4, 2021

To follow & rebase on #29.

Last fix to make entrypoint compatible for tests of #25.

@AbcSxyZ AbcSxyZ marked this pull request as draft December 4, 2021 22:43
@patricklodder patricklodder added the qa Such quality label Dec 5, 2021
@AbcSxyZ
Copy link
Contributor Author

AbcSxyZ commented Dec 5, 2021

#29 merged, rebased and ready for review.

@AbcSxyZ AbcSxyZ marked this pull request as ready for review December 5, 2021 00:32
patricklodder
patricklodder approved these changes Dec 5, 2021
View reviewed changes
Copy link
Member

@patricklodder patricklodder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. tested that I still get errors running /bin/cash instead of /bin/bash

xanimo
xanimo approved these changes Dec 5, 2021
View reviewed changes
Copy link
Member

@xanimo xanimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@patricklodder patricklodder merged commit 3b1078d into dogecoin:main Dec 5, 2021
@AbcSxyZ AbcSxyZ deleted the entrypoint-exit branch December 6, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xanimo xanimo xanimo approved these changes

@patricklodder patricklodder patricklodder approved these changes

Assignees
No one assigned
Labels
qa Such quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AbcSxyZ @patricklodder @xanimo