fix: bubble displays incorrecly in landscape mode.

the bubble cannot reach the bottom of the screen in landscape mode.

FloatingBubbleView/src/main/java/com/torrydo/floatingbubbleview/FloatingBubbleService.kt

@@ -106,7 +106,7 @@ abstract class FloatingBubbleService : Service() {
                     }
                 }
                 else -> {
-                    Log.d("<>", "change undefine: ");
+//                    Log.d("<>", "change undefine: ");
                 }
             }
             orientation = newOrientation

FloatingBubbleView/src/main/java/com/torrydo/floatingbubbleview/FloatingBubbleView.kt

@@ -132,7 +132,11 @@ internal class FloatingBubbleView(
         if (isAboveStatusBar) {
             newPoint.y = safeTopY
         } else if (isUnderSoftNavBar) {
-            newPoint.y = safeBottomY
+            if(ScreenInfo.isPortrait){
+                newPoint.y = safeBottomY
+            } else if(newPoint.y - ScreenInfo.softNavBarHeightPx > safeBottomY){
+                newPoint.y = safeBottomY + (ScreenInfo.softNavBarHeightPx)
+            }
         }
         //endregion
 

FloatingBubbleView/src/main/java/com/torrydo/floatingbubbleview/FloatingCloseBubbleView.kt

@@ -1,9 +1,7 @@
 package com.torrydo.floatingbubbleview
 
-import android.util.Log
 import android.view.LayoutInflater
 import android.view.WindowManager
-import androidx.core.content.OnConfigurationChangedProvider
 import com.torrydo.floatingbubbleview.databinding.CloseBubbleBinding
 
 internal class FloatingCloseBubbleView(
@@ -14,7 +12,7 @@ internal class FloatingCloseBubbleView(
 ) {
 
     companion object {
-        internal const val DEFAULT_PADDING_BOTTOM_PX = 20
+        internal const val DEFAULT_PADDING_BOTTOM_PX = 30
     }
 
     private var LIMIT_FLY_HEIGHT: Int
@@ -54,6 +52,10 @@ internal class FloatingCloseBubbleView(
                 ScreenInfo.statusBarHeightPx -
                 DEFAULT_PADDING_BOTTOM_PX
 
+        if (ScreenInfo.isLandscape) {
+            baseY = baseY - DEFAULT_PADDING_BOTTOM_PX + ScreenInfo.softNavBarHeightPx
+        }
+
         centerCloseBubbleX = halfScreenWidth
         centerCloseBubbleY = baseY + halfHeightPx
 

FloatingBubbleView/src/main/java/com/torrydo/floatingbubbleview/ScreenInfo.kt

@@ -5,8 +5,10 @@ import android.content.res.Configuration
 import android.content.res.Resources
 import android.os.Build
 import android.util.DisplayMetrics
+import android.util.Log
 import android.util.Size
 import android.view.Display
+import android.view.WindowInsets
 import android.view.WindowManager
 import android.view.WindowMetrics
 import androidx.annotation.RequiresApi
@@ -21,6 +23,9 @@ internal object ScreenInfo {
     internal var statusBarHeightPx = 0
     internal var softNavBarHeightPx = 0
 
+    var isPortrait = true
+    val isLandscape get() = isPortrait.not()
+
 
     // methods -------------------------------------------------------------------------------------
     fun onOrientationChanged(context: Context) {
@@ -32,9 +37,13 @@ internal object ScreenInfo {
             if(it.height >= it.width){ // portrait
                 widthPx = it.width
                 heightPx = it.height
+
+                isPortrait = true
             }else{
                 widthPx = it.width - statusBarHeightPx - softNavBarHeightPx
                 heightPx = it.height
+
+                isPortrait = false
             }
         }
 

README.md

@@ -1,7 +1,7 @@
 # 🍀Floating Bubble View
 An Android library that adds floating bubbles to your home screen 🎨, supports both XML and 💘 Jetpack Compose
 
- 
+<br>
 
 https://user-images.githubusercontent.com/85553681/223082521-789146d2-c8f7-4e54-a4d7-f281cd495404.mp4
 
@@ -400,16 +400,11 @@ public class MyService extends FloatingBubbleService {
 
     ...
 
-    /**
-     * Sets up a notification for Bubble on Android 8 and up.
-     *
-     * @param channelId The ID of the notification channel.
-     * @return The notification instance.
-     */
-    @NonNull
+    // config the initial notification for Bubble on Android 8 and up.
+    // return null if you want to show the notification later.
     @Override
-    public Notification setupNotificationBuilder(@NonNull String channelId) {
-        return new NotificationCompat.Builder(this, channelId)
+    public Notification initialNotification() {
+        return new NotificationCompat.Builder(this, channelId())
                 .setOngoing(true)
                 .setSmallIcon(R.drawable.ic_rounded_blue_diamond)
                 .setContentTitle("bubble is running")
@@ -446,19 +441,16 @@ public class MyService extends FloatingBubbleService {
 ```kotlin
 class MyService : FloatingBubbleService() {
 
-    /**
-     * Sets up a notification for Bubble on Android 8 and up.
-     * @param channelId The ID of the notification channel.
-     * @return The notification instance.
-     */
-    override fun setupNotificationBuilder(channelId: String): Notification {
-        return NotificationCompat.Builder(this, channelId)
+    // config the initial notification for Bubble on Android 8 and up.
+    // return null if you want to show the notification later.
+    open fun initialNotification(): Notification? {
+        return NotificationCompat.Builder(this, channelId())
             .setOngoing(true)
             .setSmallIcon(R.drawable.ic_rounded_blue_diamond)
             .setContentTitle("bubble is running")
-            .setContentText("click to do nothing")
-            .setPriority(NotificationCompat.PRIORITY_MIN)
+            .setPriority(PRIORITY_MIN)
             .setCategory(Notification.CATEGORY_SERVICE)
+            .setSilent(true)
             .build()
     }
 
@@ -470,6 +462,17 @@ class MyService : FloatingBubbleService() {
 
 </details>
 
+<details><summary>Notice since Android 13 ⚠ </summary>
+<br/>
+
+Starting in Android 13 (API level 33), notifications are only visible if the "POST_NOTIFICATIONS" permission is granted.<br/>
+
+> The service will run normally even if the notification is not visible. 🍀
+
+> P/s: You still need to initialize the notification before showing any view.
+
+</details>
+
 ### 3, Check if bubble is running
 
 ```java
@@ -544,6 +547,7 @@ fun SomeComposable(){
 | `showExpandableView()` | Displays the expandable-view |
 | `removeExpandableView()` | Removes the expandable-view |
 | `removeAllViews()` | Removes all views |
+| `notify(Notification)` | Displays or updates notification |
 
 <!-- | `updateNotification()`| Updates the displayed notification by calling (again) `setupNotificationBuilder()` | -->
 

app/src/main/AndroidManifest.xml

@@ -5,6 +5,8 @@
 <!--    <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>-->
 <!--    <uses-permission android:name="android.permission.FOREGROUND_SERVICE"/>-->
 
+    <uses-permission android:name="android.permission.POST_NOTIFICATIONS"/>
+
     <application
         android:allowBackup="true"
         android:icon="@mipmap/ic_launcher"

gradle.properties

@@ -27,8 +27,8 @@ RELEASE_SIGNING_ENABLED=true
 
 GROUP=io.github.torrydo
 POM_ARTIFACT_ID=floating-bubble-view
-VERSION_NAME=0.5.2
-#prev: 0.5.1
+VERSION_NAME=0.5.3
+#prev: 0.5.2
 
 POM_NAME=FloatingBubbleView
 POM_PACKAGING=aar