Conversation
If you find yourself using "also" in a commit message, it probably means you should have 2 commits. What was wrong with the escaping, and how did you fix it? |
|
Sure. |
|
|
|
|
Please include that explanation in your commit message. |
|
@mvorisek please review. |
| } | ||
|
|
||
| $regex .= preg_quote($prefix, '/'); | ||
| $regex .= preg_quote($prefix); |
There was a problem hiding this comment.
PR LGTM and I like this change, it seem / was even wrong here as later ~ delimtier was used.
|
@vrana please improve your commit message according to the contributing guide. Specifically, please wrap the body of your commit message at 72 chars. |
`/` was unnecessarily escaped even though the delimiter was `~`. Using delimiter `~` required escaping it in `$boundaries` and elsewhere even though these are `preg_quote`'d later. Using `()` as the delimiter allows treating all characters the same.
|
Thanks @vrana ! |
3 participants
Also fix regular expression escaping