Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create stubs instead of mocks #6564

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Create stubs instead of mocks #6564

merged 1 commit into from
Oct 21, 2024

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Oct 21, 2024

Q A
Type improvement
Fixed issues

Summary

This is a followup of #6558, I have touched only what previous PR touched.

@greg0ire requested to use stubs where there are no expectations

image

@simPod simPod changed the title Fix typo in PostgreSql documentation reference Create stubs instead of mocks Oct 21, 2024
@simPod simPod marked this pull request as ready for review October 21, 2024 08:49
@greg0ire greg0ire added this to the 3.9.4 milestone Oct 21, 2024
@simPod
Copy link
Contributor Author

simPod commented Oct 21, 2024

btw any idea how to make codecov pass?

image

@greg0ire
Copy link
Member

I'd say get somebody to answer codecov/codecov-action#1580

@derrabus derrabus merged commit b87a89f into doctrine:3.9.x Oct 21, 2024
97 of 98 checks passed
derrabus added a commit to derrabus/dbal that referenced this pull request Oct 21, 2024
* 3.9.x:
  Create stubs instead of mocks (doctrine#6564)
  test: remove ->expects(self::any())
  Fix typo in PostgreSql documentation reference
@simPod simPod deleted the stub branch October 21, 2024 11:28
derrabus added a commit that referenced this pull request Oct 21, 2024
* 4.2.x:
  Create stubs instead of mocks (#6564)
  [Bug] Query Cache mangled if saved by-reference (#6552)
  test: remove ->expects(self::any())
  Fix typo in PostgreSql documentation reference
  fix
  Acknowledge the existence of 3.10 (#6553)
  test: cover nested transactions
derrabus added a commit that referenced this pull request Oct 21, 2024
* 4.3.x:
  Create stubs instead of mocks (#6564)
  [Bug] Query Cache mangled if saved by-reference (#6552)
  test: remove ->expects(self::any())
  Fix typo in PostgreSql documentation reference
  fix
  Acknowledge the existence of 3.10 (#6553)
  Simplify tracking implicitly created indexes
  Remove handling unuique constraint column names as associative array (#6549)
  test: cover nested transactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants