refactor: drop master

doctrine · Apr 14, 2022 · 4f4387c · 4f4387c
1 parent 035c919
commit 4f4387c
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 15 deletions.
diff --git a/Command/CreateDatabaseDoctrineCommand.php b/Command/CreateDatabaseDoctrineCommand.php
@@ -54,15 +54,10 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         $params = $connection->getParams();
 
-        // Since doctrine/dbal 2.11 master has been replaced by primary
         if (isset($params['primary'])) {
             $params = $params['primary'];
         }
 
-        if (isset($params['master'])) {
-            $params = $params['master'];
-        }
-
         // Cannot inject `shard` option in parent::getDoctrineConnection
         // cause it will try to connect to a non-existing database
         if (isset($params['shards'])) {

diff --git a/Command/DropDatabaseDoctrineCommand.php b/Command/DropDatabaseDoctrineCommand.php
@@ -65,15 +65,10 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         $params = $connection->getParams();
 
-        // Since doctrine/dbal 2.11 master has been replaced by primary
         if (isset($params['primary'])) {
             $params = $params['primary'];
         }
 
-        if (isset($params['master'])) {
-            $params = $params['master'];
-        }
-
         if (isset($params['shards'])) {
             $shards = $params['shards'];
             // Default select global

diff --git a/DependencyInjection/DoctrineExtension.php b/DependencyInjection/DoctrineExtension.php
@@ -357,7 +357,7 @@ protected function getConnectionOptions(array $connection): array
         }
 
         if (! empty($options['slaves']) && ! empty($options['replica']) && ! empty($options['shards'])) {
-            throw new InvalidArgumentException('Sharding and master-slave connection cannot be used together');
+            throw new InvalidArgumentException('Sharding and primary-replica connection cannot be used together');
         }
 
         foreach (['shards', 'replica', 'slaves'] as $connectionKey) {
@@ -382,7 +382,6 @@ protected function getConnectionOptions(array $connection): array
                 'shardChoser' => true,
                 'platform' => true,
                 'slaves' => true,
-                'master' => true,
                 'primary' => true,
                 'replica' => true,
                 'shards' => true,

diff --git a/Tests/DependencyInjection/AbstractDoctrineExtensionTest.php b/Tests/DependencyInjection/AbstractDoctrineExtensionTest.php
@@ -185,9 +185,9 @@ public function testDbalDbnameSuffix(): void
         $this->assertSame('_test', $config['dbname_suffix']);
     }
 
-    public function testDbalLoadSingleMasterSlaveConnection(): void
+    public function testDbalLoadSinglePrimaryReplicaConnection(): void
     {
-        $container = $this->loadContainer('dbal_service_single_master_slave_connection');
+        $container = $this->loadContainer('dbal_service_single_primary_replica_connection');
         $param     = $container->getDefinition('doctrine.dbal.default_connection')->getArgument(0);
 
         $this->assertEquals(PrimaryReadReplicaConnection::class, $param['wrapperClass']);
@@ -202,7 +202,7 @@ public function testDbalLoadSingleMasterSlaveConnection(): void
                 'unix_socket' => '/path/to/mysqld.sock',
                 'driverOptions' => [PDO::ATTR_STRINGIFY_FETCHES => 1],
             ],
-            $param['primary'] ?? $param['master'] // TODO: Remove 'master' support here when we require dbal >= 2.11
+            $param['primary']
         );
         $this->assertEquals(
             [

diff --git a/...ervice_single_master_slave_connection.xml → ...ice_single_primary_replica_connection.xml b/...ervice_single_master_slave_connection.xml → ...ice_single_primary_replica_connection.xml
diff --git a/...ervice_single_master_slave_connection.yml → ...ice_single_primary_replica_connection.yml b/...ervice_single_master_slave_connection.yml → ...ice_single_primary_replica_connection.yml