Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump behat/transliterator to ^1.3 #2860

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Kaaly
Copy link

@Kaaly Kaaly commented Aug 29, 2024

Composer say project is compatible with PHP 7.4 but require behat/transliterator:^1.2 which is not compatible with PHP 7.4 so bump behat/transliterator to ^1.3 min.

Bump behat/transliterator to ^1.3 to be fully compatible with PHP 7.4
@mbabker
Copy link
Contributor

mbabker commented Aug 29, 2024

Looking at the diff between 1.2 and 1.3, the only thing that changed was replacing deprecated syntax. Functionally, there's no real difference between the two versions.

(Not saying there's no reason to accept this, but the older version of the transliterator library (which the odds of getting installed outside of a composer update --prefer-lowest type of run should be pretty much zero) would at least work on PHP 7.4)

@stof
Copy link
Contributor

stof commented Oct 7, 2024

Also, ^1.3 and ^1.2 has the same upper bound. So this PR is not adding support for anything. It only removes support for some versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants