Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #2822

Closed

Conversation

andreybolonin
Copy link
Contributor

According to #2821

@mbabker
Copy link
Contributor

mbabker commented Jun 24, 2024

I'm honestly half tempted to suggest to just close this unless you're willing to rebuild the table entirely (or just wipe out the table). The heading "Compatible Doctrine ORM & Common Library" implies compatibility with doctrine/orm and doctrine/common, which don't have the same versioning scheme, and does nothing to note compatibility with doctrine/mongodb-odm or other required Doctrine libraries (like the DBAL or Persistence packages which are more relevant here than doctrine/common).

Personally, I think I'd just update the README to note the supported versions as of now and not try to keep a matrix for what older versions did or did not support (a lot of that can be pulled out of the composer.json file for folks who really need it), so instead of a table I'd use this list:

  • DBAL: ^3.2
  • ORM: ^2.14 or ^3.0
  • MongoDB ODM: ^2.3

(And yes, the DBAL callout is important because of #2502 which relates to DBAL features and not the ORM)

@franmomu
Copy link
Collaborator

thanks @andreybolonin, I've updated #2821 with @mbabker's suggestion. I don't think the older versions are useful there.

@franmomu franmomu closed this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants