Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. ORM 3 compat fixes #2812

Merged
merged 7 commits into from
Jun 9, 2024

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Jun 9, 2024

Ref: #2708

This PR contains a lot of the smaller fixes left over in my running compat branch. With this, theoretically, the next PR is the last one dealing with this all.

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 78.12500% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.36%. Comparing base (0632ab1) to head (30568a1).
Report is 29 commits behind head on main.

Files Patch % Lines
src/Tree/Strategy/ORM/Closure.php 68.42% 6 Missing ⚠️
...ranslatable/Query/TreeWalker/TranslationWalker.php 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2812      +/-   ##
==========================================
- Coverage   78.75%   78.36%   -0.39%     
==========================================
  Files         163      167       +4     
  Lines        8593     8626      +33     
==========================================
- Hits         6767     6760       -7     
- Misses       1826     1866      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@franmomu franmomu merged commit 7bb3870 into doctrine-extensions:main Jun 9, 2024
16 of 18 checks passed
@franmomu
Copy link
Collaborator

franmomu commented Jun 9, 2024

thanks @mbabker!

@mbabker mbabker deleted the orm-3-compat-fixes branch June 9, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants