Update SoftDeleteable to work with Doctrine 3.1

[elfantome]

Update Gedmo\SoftDeleteable\Filter\SoftDeleteableFilter::addFilterConstraint signature to be compatible with Doctrine\ORM\Query\Filter\SQLFilter::addFilterConstraint

[mbabker]

Unfortunately this change breaks compatibility with ORM 2.x.

Fatal error: Declaration of Gedmo\SoftDeleteable\Filter\SoftDeleteableFilter::addFilterConstraint(Doctrine\ORM\Mapping\ClassMetadata $targetEntity, string $targetTableAlias): string must be compatible with Doctrine\ORM\Query\Filter\SQLFilter::addFilterConstraint(Doctrine\ORM\Mapping\ClassMetadata $targetEntity, $targetTableAlias) in /src/SoftDeleteable/Filter/SoftDeleteableFilter.php on line 54

[elfantome]

Unfortunately this change breaks compatibility with ORM 2.x.

Fatal error: Declaration of Gedmo\SoftDeleteable\Filter\SoftDeleteableFilter::addFilterConstraint(Doctrine\ORM\Mapping\ClassMetadata $targetEntity, string $targetTableAlias): string must be compatible with Doctrine\ORM\Query\Filter\SQLFilter::addFilterConstraint(Doctrine\ORM\Mapping\ClassMetadata $targetEntity, $targetTableAlias) in /src/SoftDeleteable/Filter/SoftDeleteableFilter.php on line 54

In this case, maybe bumping the version number with a new release can solve the problem?

[mbabker]

I just looked at the install stats. It is way too early to consider dropping ORM 2.x support, and the volunteer resources don't exist to support two major version branches of this package.

There might be a way to change the signature in a way to support both versions (like only adding the return type without the param type), but based on numbers and resources only supporting ORM 3.x right now is not the right decision.

[elfantome]

Makes sense.
I updated my PR to only add a return type to the method to keep compatibility with ORM 2.x

[Seb33300]

Needs to be reverted

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.40%. Comparing base (0632ab1) to head (18dd98c).
Report is 38 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2801      +/-   ##
==========================================
- Coverage   78.75%   78.40%   -0.35%     
==========================================
  Files         163      167       +4     
  Lines        8593     8627      +34     
==========================================
- Hits         6767     6764       -3     
- Misses       1826     1863      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[franmomu]

thanks @elfantome!