-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests without doctrine/annotations
installed
#2781
Run tests without doctrine/annotations
installed
#2781
Conversation
0b578da
to
5c48fc5
Compare
@franmomu The PHP 8 builds failing on this PR are all with |
I'm this week AFK, I'll try to take a look at that, but it could be the support of transactions in doctrine/mongodb-odm#2586 that includes some refactors |
Apparently it is because doctrine/mongodb-odm#2580 (part of doctrine/mongodb-odm#2586), when deferring the clean up of changesets at the of the commit, maybe we are doing something we shouldn't in https://github.com/doctrine-extensions/DoctrineExtensions/blob/8d658b4d22977e3b72f02bfe4e68b2df0ba586aa/src/Tree/TreeListener.php (or there is something wrong with the refactor), I'll try to take a deeper look |
This should work now after #2811 |
…er to avoid unintended overwrites due to namespaces
817d402
to
9837dfd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2781 +/- ##
==========================================
- Coverage 78.75% 78.43% -0.32%
==========================================
Files 163 167 +4
Lines 8593 8614 +21
==========================================
- Hits 6767 6756 -11
- Misses 1826 1858 +32 ☔ View full report in Codecov by Sentry. |
thanks @mbabker! |
MongoDB ODM 2.7 dropped the hard dependency, so let's do a smoke test build without the annotations package installed here and see what happens...