Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests without doctrine/annotations installed #2781

Merged
merged 4 commits into from
Jun 9, 2024

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Mar 19, 2024

MongoDB ODM 2.7 dropped the hard dependency, so let's do a smoke test build without the annotations package installed here and see what happens...

@mbabker mbabker force-pushed the no-annotation-build branch 2 times, most recently from 0b578da to 5c48fc5 Compare March 19, 2024 13:05
@mbabker
Copy link
Contributor Author

mbabker commented Mar 19, 2024

@franmomu The PHP 8 builds failing on this PR are all with doctrine/mongodb-odm 2.7 installed, the passing builds on lower versions install 2.5.5. And there weren't any failures on the last CI build for one of my PRs a couple weeks ago with 2.6.3. Did something change in the ODM needing an update here?

@franmomu
Copy link
Collaborator

@franmomu The PHP 8 builds failing on this PR are all with doctrine/mongodb-odm 2.7 installed, the passing builds on lower versions install 2.5.5. And there weren't any failures on the last CI build for one of my PRs a couple weeks ago with 2.6.3. Did something change in the ODM needing an update here?

I'm this week AFK, I'll try to take a look at that, but it could be the support of transactions in doctrine/mongodb-odm#2586 that includes some refactors

@franmomu
Copy link
Collaborator

@franmomu The PHP 8 builds failing on this PR are all with doctrine/mongodb-odm 2.7 installed, the passing builds on lower versions install 2.5.5. And there weren't any failures on the last CI build for one of my PRs a couple weeks ago with 2.6.3. Did something change in the ODM needing an update here?

I'm this week AFK, I'll try to take a look at that, but it could be the support of transactions in doctrine/mongodb-odm#2586 that includes some refactors

Apparently it is because doctrine/mongodb-odm#2580 (part of doctrine/mongodb-odm#2586), when deferring the clean up of changesets at the of the commit, maybe we are doing something we shouldn't in https://github.com/doctrine-extensions/DoctrineExtensions/blob/8d658b4d22977e3b72f02bfe4e68b2df0ba586aa/src/Tree/TreeListener.php (or there is something wrong with the refactor), I'll try to take a deeper look

@franmomu
Copy link
Collaborator

franmomu commented Jun 9, 2024

This should work now after #2811

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.43%. Comparing base (0632ab1) to head (9837dfd).
Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2781      +/-   ##
==========================================
- Coverage   78.75%   78.43%   -0.32%     
==========================================
  Files         163      167       +4     
  Lines        8593     8614      +21     
==========================================
- Hits         6767     6756      -11     
- Misses       1826     1858      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbabker mbabker marked this pull request as ready for review June 9, 2024 16:00
@mbabker mbabker mentioned this pull request Jun 9, 2024
@franmomu franmomu merged commit c16c401 into doctrine-extensions:main Jun 9, 2024
19 of 20 checks passed
@franmomu
Copy link
Collaborator

franmomu commented Jun 9, 2024

thanks @mbabker!

@mbabker mbabker deleted the no-annotation-build branch June 9, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants