Use constants for arbitrary annotation values #2675
Conversation
phansys
force-pushed
the
annotation_values
branch
from
ae3fdd3
to
32a8715
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2675 +/- ##
==========================================
- Coverage 79.22% 79.20% -0.02%
==========================================
Files 161 161
Lines 8412 8412
==========================================
- Hits 6664 6663 -1
- Misses 1748 1749 +1 ☔ View full report in Codecov by Sentry. |
phansys
force-pushed
the
annotation_values
branch
3 times, most recently
from
a86e342
to
fc4c9ec
Compare
phansys
force-pushed
the
annotation_values
branch
from
fc4c9ec
to
7facd0b
Compare
| namespace Gedmo\Mapping\Annotation; | ||
|
|
||
| /** | ||
| * @internal |
There was a problem hiding this comment.
If you expect projects to use those constants, I don't think it should be internal
| /** | ||
| * @internal | ||
| */ | ||
| interface TrackingAwareAnnotationInterface extends Annotation |
There was a problem hiding this comment.
instead of an interface extending Annotation, I would suggest putting those constants on an enum-like class (being final and forbidding instantiation thanks to a private constructor).
If the PHP requirements were allowing it, those events would be a good candidate for an actual enum, as it is a closed list.
| public const STYLE_LOWER = 'lower'; | ||
| public const STYLE_UPPER = 'upper'; | ||
| public const STYLE_CAMEL = 'camel'; | ||
| public const STYLE_ORIGINAL = 'default'; |
There was a problem hiding this comment.
Those styles being a closed list also look like a good candidate for an enum class
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
To Do: