Feature/drop support for php 7.3 #2636
Conversation
There was a problem hiding this comment.
This change should be supported by Rector:
Line 24 in 070f350
Chris53897
force-pushed
the
feature/drop-support-for-php-7.3
branch
from
070f350
to
5b2fc87
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2636 +/- ##
==========================================
- Coverage 79.67% 79.65% -0.03%
==========================================
Files 162 162
Lines 8452 8424 -28
==========================================
- Hits 6734 6710 -24
+ Misses 1718 1714 -4
☔ View full report in Codecov by Sentry. |
|
Using rector as you suggested will introduce a lot of BC Breaks. @TomasVotruba Is there a safe way to autoupdate with rector for libraries without BC Breaks? I would suggest to wait until the problems with doctrine/orm 2.16 are fixed. |
franmomu
force-pushed
the
feature/drop-support-for-php-7.3
branch
5 times, most recently
from
36982bd
to
b8daa69
Compare
franmomu
force-pushed
the
feature/drop-support-for-php-7.3
branch
2 times, most recently
from
25f252a
to
b56c185
Compare
franmomu
force-pushed
the
feature/drop-support-for-php-7.3
branch
from
b56c185
to
23ed9ff
Compare
There was a problem hiding this comment.
Maybe we could also implement the rule set @PHP74Migration from PHP-CS-Fixer.
|
Thanks @Chris53897! |
* feat: drop support of php <= 7.3 * feat: drop support of php <= 7.3 * Update code to PHP 7.4 * Use @PHP74Migration from PHP-CS-Fixer --------- Co-authored-by: Christopher Georg <[email protected]> Co-authored-by: Fran Moreno <[email protected]>
#2635
Needs a check for BC breaks.