Honor return type for __set()
#2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2630 +/- ##
==========================================
- Coverage 79.27% 79.26% -0.02%
==========================================
Files 161 161
Lines 8400 8400
==========================================
- Hits 6659 6658 -1
- Misses 1741 1742 +1
☔ View full report in Codecov by Sentry. |
phansys
force-pushed
the
translation_proxy_set
branch
from
7e3fbfa
to
b0dfeaf
Compare
phansys
force-pushed
the
translation_proxy_set
branch
from
b0dfeaf
to
ef25225
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return type for
__set()is defined asvoid: https://www.php.net/manual/en/language.oop5.overloading.php#object.set.This change fixes the findings detected by PHPStan, those that are currently breaking the CI pipeline.
Although it can be technically considered a BC break, I think this is a minor change, as there is no way to get the return value when this method is called.