Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix deprecation for AbstractPlatform->getIsNullExpression() #2623

Conversation

Chris53897
Copy link
Contributor

@Chris53897 Chris53897 commented Jun 7, 2023

User Deprecated: AbstractPlatform::getIsNullExpression() is deprecated. Use IS NULL in SQL instead. (AbstractPlatform.php:1180 called by SoftDeleteableFilter.php:73, doctrine/dbal#4724, package doctrine/dbal)

Copy link

@ndench ndench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Chris53897!

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (55e9499) 79.27% compared to head (b9b289f) 79.29%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2623      +/-   ##
==========================================
+ Coverage   79.27%   79.29%   +0.01%     
==========================================
  Files         161      161              
  Lines        8400     8412      +12     
==========================================
+ Hits         6659     6670      +11     
- Misses       1741     1742       +1     
Impacted Files Coverage Δ
src/SoftDeleteable/Filter/SoftDeleteableFilter.php 95.12% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@phansys phansys merged commit 0db3937 into doctrine-extensions:main Jun 19, 2023
18 checks passed
@phansys
Copy link
Collaborator

phansys commented Jun 19, 2023

Thank you @Chris53897!

@Chris53897 Chris53897 deleted the feature/fix-deprecation-getIsNullExpression branch June 19, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants