Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make dataproviders static for phpunit 10 #2622

Conversation

Chris53897
Copy link
Contributor

to prepare for phpunit 10

@phansys phansys closed this Jun 19, 2023
@phansys phansys reopened this Jun 19, 2023
@phansys
Copy link
Collaborator

phansys commented Jun 19, 2023

phpunit/phpunit:10.0.0 was released on 2023-02-03.
Could you please confirm if it is compatible with our setup?

"phpunit/phpunit": "^8.5 || ^9.5",

@Chris53897
Copy link
Contributor Author

This bundle/tests are not yet compatible with PHPUnit 10.

Direct: Tests withConsecutive() needs to be rewritten. I am not sure if there is more. I prepared a Branch locally
Indirect: symfony/phpunit-bridge is not yet compatible

This is just to prepare for version 10. Tests without static data generators will raise a warning in PHPUnit 10.

@Chris53897
Copy link
Contributor Author

Maybe i got your question wrong. (The runner for php 7.3 and 8.0 are stuck.)
These changes should be safe for older phpunit version. If this was your question did targed.

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (774a11f) 79.22% compared to head (e2851bf) 79.22%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2622   +/-   ##
=======================================
  Coverage   79.22%   79.22%           
=======================================
  Files         161      161           
  Lines        8410     8410           
=======================================
  Hits         6663     6663           
  Misses       1747     1747           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@phansys phansys closed this Jun 19, 2023
@phansys phansys reopened this Jun 19, 2023
@phansys
Copy link
Collaborator

phansys commented Jun 19, 2023

Maybe i got your question wrong. (The runner for php 7.3 and 8.0 are stuck.)

No, that's exactly what I was wondering. Thanks.

@Chris53897 Chris53897 force-pushed the feature/phpunit10-static-data-providers branch from 792dda6 to 254ddf5 Compare June 19, 2023 20:57
@Chris53897
Copy link
Contributor Author

8.1 runner is stucked again i guess ;(

@phansys phansys merged commit 95bc3c8 into doctrine-extensions:main Jun 19, 2023
18 checks passed
@phansys
Copy link
Collaborator

phansys commented Jun 19, 2023

Thanks @Chris53897!

@Chris53897 Chris53897 deleted the feature/phpunit10-static-data-providers branch June 19, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants